Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jump label color to dracula themes #9973

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

yo-main
Copy link
Contributor

@yo-main yo-main commented Mar 23, 2024

Update dracula themes with the new jump-label parameter

@yo-main yo-main changed the title feat: add jump label color to dracula themes Add jump label color to dracula themes Mar 23, 2024
@pascalkuthe pascalkuthe merged commit 8f65bfe into helix-editor:master Mar 23, 2024
6 checks passed
@yo-main yo-main deleted the add-jump-labal-dracula branch March 23, 2024 18:02
@@ -120,6 +120,7 @@
"ui.virtual.inlay-hint" = { fg = "cyan" }
"ui.virtual.inlay-hint.parameter" = { fg = "cyan", modifiers = ["italic", "dim"] }
"ui.virtual.inlay-hint.type" = { fg = "cyan", modifiers = ["italic", "dim"] }
"ui.virtual.jump-label" = { fg = "pink", modifiers = ["bold"] }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried out this theme, I suspect this is a "me" problem but wanted to check-in

Should fg be updating the actual text characters colour?
Using this instead of my custom one and it just seems to flip the characters without additional styles? (I'm using iTerm2 on MacOS, and I may not have that set up properly)

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah it's supposed to highlight the 2 first characters in pink. Example:
image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yo-main Ah okay yeah I can see how that fits the Dracula style well now! Thanks for the screenshot, I'll keep poking around my Terminal's settings then.

I'm using reversed in my custom theme, which is pretty in-your-face but makes it clear something has happened (especially with how often I've been pairing with other devs recently)
image

Desdaemon pushed a commit to Desdaemon/helix that referenced this pull request Mar 26, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 4, 2024
postsolar pushed a commit to postsolar/helix that referenced this pull request Apr 20, 2024
mtoohey31 pushed a commit to mtoohey31/helix that referenced this pull request Jun 2, 2024
Vulpesx pushed a commit to Vulpesx/helix that referenced this pull request Jun 7, 2024
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants