-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jump label color to dracula themes #9973
Add jump label color to dracula themes #9973
Conversation
@@ -120,6 +120,7 @@ | |||
"ui.virtual.inlay-hint" = { fg = "cyan" } | |||
"ui.virtual.inlay-hint.parameter" = { fg = "cyan", modifiers = ["italic", "dim"] } | |||
"ui.virtual.inlay-hint.type" = { fg = "cyan", modifiers = ["italic", "dim"] } | |||
"ui.virtual.jump-label" = { fg = "pink", modifiers = ["bold"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tried out this theme, I suspect this is a "me" problem but wanted to check-in
Should fg be updating the actual text characters colour?
Using this instead of my custom one and it just seems to flip the characters without additional styles? (I'm using iTerm2 on MacOS, and I may not have that set up properly)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yo-main Ah okay yeah I can see how that fits the Dracula style well now! Thanks for the screenshot, I'll keep poking around my Terminal's settings then.
I'm using reversed
in my custom theme, which is pretty in-your-face but makes it clear something has happened (especially with how often I've been pairing with other devs recently)
Update dracula themes with the new jump-label parameter